Some more performance improvements #313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
krassowski
reviewed
Sep 2, 2024
martinRenou
force-pushed
the
more_perf
branch
from
7766ec5 to
dec91f5
Compare
|
As you requested, the maximum number of shown items is now configurable: Screencast.from.2024-09-03.10-49-56.mp4 |
krassowski
approved these changes
Sep 3, 2024
There was a problem hiding this comment.
Thank you for adding the setting - it turned out a bit more involved then I anticipated. It's great to have it so easily configurable - this will ensure that existing users will not get frustrated by being unable to see more items.
Just tiny suggestions on the setting schema to make it easier to use :)
Co-authored-by: Michał Krassowski <[email protected]>
|
Thanks for the review and the suggestions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still playing with my case from #311 for improving #307
I can go down to
487 μs ± 10.2 μs per loop (mean ± std. dev. of 7 runs, 1,000 loops each)by improving the processing of big lists and tuples.